Repository navigation
Conversation
func25
marked this pull request as ready for review
September 23, 2026 10:30
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
func25
changed the title
func25
force-pushed
the
metrics-http-error
branch
from
September 23, 2026 11:12
d1fb0aa to
da062dc
Compare
func25
changed the title
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
vl_http_errors_totaldoesn't increase when inserts were rejected because vlstorage was in read-only mode (e.g. out of disk space), so users had to compute failures asvl_http_requests_total - vl_http_request_duration_seconds_count.vl_http_errors_totalwhenCanWriteData()fails for jsonline, native, multitenant native, internal insert, splunk and opentelemetry (interestingly journald already does this)vl_http_errors_totalfor loki, elasticsearch and datadogI keeps the minimal fix, we can consider unifying error handling, but the problem is jsonline counts error per invalid log line inside a request, not per request. Not sure this is expected.